[PATCH] D115874: [M68k][GlobalISel] Implement lowerCall based on M68k calling convention

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/M68k/GISel/M68kCallLowering.cpp:199
+  CCAssignFn *AssignFn =
+      TLI.getCCAssignFn(F.getCallingConv(), false, F.isVarArg());
+  OutgoingValueAssigner Assigner(AssignFn);
----------------
0x59616e wrote:
> arsenm wrote:
> > Using F.getCallingConv() is using the calling function's calling convention. You want Info.CallConv like above
> Done. Thanks :)
Same with F.isVarArg


================
Comment at: llvm/lib/Target/M68k/GISel/M68kCallLowering.cpp:215
+    CCAssignFn *RetAssignFn =
+        TLI.getCCAssignFn(F.getCallingConv(), true, F.isVarArg());
+
----------------
0x59616e wrote:
> arsenm wrote:
> > Ditto
> Done. Thanks :)
Same with F.isVarArg


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115874/new/

https://reviews.llvm.org/D115874