[PATCH] D119203: [test][llvm-objcopy/mac] Fix invalid strip tests

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 16:42:46 PST 2022


keith created this revision.
Herald added a reviewer: alexander-shaposhnikov.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald added a subscriber: abrachet.
keith requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

I discovered some of these tests had `cmp` statements that weren't
actually being run. I had also recently copied this broken setup for a
new test around chained fixups. Fixing this revealed that the binaries
did differ because of their code signature so I regenerated the fixture
here with this source:

  c
  int main() {
     return 0;
  }

Passing `-Wl,-no_adhoc_codesign` on my M1 <https://reviews.llvm.org/M1> machine to make sure it didn't
get any signature.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119203

Files:
  llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-chained-fixups.yaml
  llvm/test/tools/llvm-objcopy/MachO/strip-all.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119203.406649.patch
Type: text/x-patch
Size: 7911 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220208/25f4cd7d/attachment.bin>


More information about the llvm-commits mailing list