[PATCH] D119182: [Bitstream] Temporarily disable UBSan for invalid bitcode tests. This fixes failing sanitizer buildbots.

Andrew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 13:54:30 PST 2022


browneee added inline comments.


================
Comment at: llvm/test/Bitcode/invalid-no-ubsan.test:11-19
+RUN: not llvm-dis -disable-output %p/Inputs/size-not-plausible.bc 2>&1 | \
+RUN:   FileCheck --check-prefix=SIZE-NOT-PLAUSIBLE %s
+
+SIZE-NOT-PLAUSIBLE: Size is not plausible
+
+RUN: not llvm-dis -disable-output %p/Inputs/invalid-value-symbol-table-2.bc 2>&1 | \
+RUN:   FileCheck --check-prefix=INVALID-VALUE-SYMBOL-TABLE-2 %s
----------------
vitalybuka wrote:
> Please don't move lines unnecessary
> 
Do you mean do not move these lines into a different file?

Then `UNSUPPORTED: ubsan` would disable all of the other tests that do work under UBSan. That could allow more UB to enter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119182/new/

https://reviews.llvm.org/D119182



More information about the llvm-commits mailing list