[PATCH] D118843: [x86] avoid false dependency stall on 'sbb' with same source reg

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 13:13:54 PST 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:468
+      unsigned Opcode = N->getOpcode();
+      assert(Opcode == X86ISD::SBB || Opcode == X86ISD::SETCC_CARRY &&
+             "Unexpected opcode for SBB materialization");
----------------
This has a -Wparentheses warning with gcc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118843/new/

https://reviews.llvm.org/D118843



More information about the llvm-commits mailing list