[PATCH] D111530: [TargetLowering] Optimize expanded SRL/SHL fed into SETCC ne/eq 0

[Filipp Zhinkin via Phabricator via llvm-commits]

fzhinkin added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:3572
+  Scan = [&Scan, &MatchShifts, &Result, OpSizeInBits](const SDValue &Value,
+                                                      unsigned Depth) {
+    if (Depth >= SelectionDAG::MaxRecursionDepth || !Value->hasOneUse())
----------------
RKSimon wrote:
> You might be better off pulling this lambda out as static helper function instead of relying on recursive lambda calls?
Yes, thanks for suggestion. I think it'll be better to move both lambdas as well result reduction to a helper class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111530/new/

https://reviews.llvm.org/D111530