[PATCH] D119111: [X86] Invert a vector select IR canonicalization with a binop identity constant

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

Thanks for working on this. 
I have a patch to move the existing code over to DAGCombiner with a TLI hook that is only enabled for x86 currently, so it would be effectively NFC.
That would allow us to avoid adding code for custom combining fmul/fdiv to x86 (just add cases for the new opcodes in DAGCombiner). 
I'm not sure if one way is more efficient than the other, but let me post that for review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119111/new/

https://reviews.llvm.org/D119111