[PATCH] D119028: [NFC] Refactor llvm-nm symbol sorting

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added a comment.

In D119028#3300831 <https://reviews.llvm.org/D119028#3300831>, @jhenderson wrote:

>> Change the title/commit summary to "[NFC] Refactor llvm-nm symbol sorting" (will need the additional patch mentioned inline).
>
> Patch title still doesn't match the suggested correction.



In D119028#3300831 <https://reviews.llvm.org/D119028#3300831>, @jhenderson wrote:

>> Change the title/commit summary to "[NFC] Refactor llvm-nm symbol sorting" (will need the additional patch mentioned inline).
>
> Patch title still doesn't match the suggested correction.

    I do not think we need to additional patch for it. I think over using std::sort it is OK for export symbol list, (it is not matter for us, it the order of symbol changed, if the two symbol is equal at symbol name and visibility, and we will remove the duplication symbol finally). 
  and for other functionality, the code is already using the std::sort , we do not need to change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119028/new/

https://reviews.llvm.org/D119028