[PATCH] D118132: [demangler] stricter NestedName parsing

Nathan Sidwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 08:01:10 PST 2022


urnathan marked 3 inline comments as done.
urnathan added a comment.

In D118132#3299846 <https://reviews.llvm.org/D118132#3299846>, @ChuanqiXu wrote:

> We need to format this before landing.

I'm going to decline that. 
(a) the comment formatting is breaking the long lines of the grammar -- and making that hard to read.  Also, not lines I've changed.
(b) the if(state) ... formatting is idiomatic in this file.  Also, not something I've changed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118132/new/

https://reviews.llvm.org/D118132



More information about the llvm-commits mailing list