[PATCH] D117923: BuildLibCalls: add allocalign attributes for memalign and aligned_alloc

[James Y Knight via Phabricator via llvm-commits]

jyknight added a comment.

In D117923#3262389 <https://reviews.llvm.org/D117923#3262389>, @durin42 wrote:

> Question for reviewers: if I can do something similar for the aligned versions of `::operator::new` in C++, we can remove a column from the table in `MemoryBuiltins.cpp`.  Should that happen in clang, or someplace else? What am I looking for in clang to make that happen?

I suggest adding the C++ calls here too, especially if that enables removing the column from MemoryBuiltins, as you suggest.

I think only once we've added all of the attributes required to enable us to eliminate the C++ operators from MemoryBuiltins, then we can delete the special handling of C++ operator new in LLVM. and move all the attribute additions into Clang, all at once. (It just seems simpler to deal with by batching it up that way, instead of moving things across the llvm/clang layer piecemeal).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117923/new/

https://reviews.llvm.org/D117923