[PATCH] D118468: [cross-project-tests] XFAIL llgdb-tests when gdb can't read clang's DWARF

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 7 04:38:58 PST 2022


Orlando added inline comments.


================
Comment at: cross-project-tests/lit.cfg.py:220
+    return None
+  return gdb_vers_lines[0].strip().partition('GNU gdb (GDB) ')[2]
+
----------------
Orlando wrote:
> jmorse wrote:
> > Having the same length-check for `[2]` as on the earlier few lines would future proof this code.
> `partition` returns a 3-tuple of strings ([docs](https://docs.python.org/3/library/stdtypes.html#str.partition)).
I have now updated this to check that the partition isn't zero-length though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118468/new/

https://reviews.llvm.org/D118468



More information about the llvm-commits mailing list