[PATCH] D119038: [BOLT] Fix bolt_rt_instr for osx build condition
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 7 03:40:14 PST 2022
alexander-shaposhnikov added inline comments.
================
Comment at: bolt/runtime/CMakeLists.txt:33
-if (CMAKE_CXX_COMPILER_ID MATCHES ".*Clang.*")
+if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin")
add_library(bolt_rt_instr_osx STATIC
----------------
alexander-shaposhnikov wrote:
> unless I'm missing something this appears to be incorrect.
> Basically we used to build the osx runtime library regardless of the host platform
> (clang works as a cross compiler).
@Amir - the runtime is not linked into BOLT, instead, it's used for creating the final output, thus the target for which we are building the project is not directly related to the target platforms supported by the tool itself.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119038/new/
https://reviews.llvm.org/D119038
More information about the llvm-commits
mailing list