[PATCH] D118415: AMDGPU: Reserve v32 if we may need to copy between AGPRs on gfx908
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 4 12:12:39 PST 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:601
+ } else {
+ Tmp = RS.scavengeRegister(&AMDGPU::VGPR_32RegClass, 0);
}
----------------
rampitec wrote:
> rampitec wrote:
> > It misses error reporting and setRegUsed call.
> Ping.
The error reporting was pointless because if !AllowSpill, scavengeRegister emits the error
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118415/new/
https://reviews.llvm.org/D118415
More information about the llvm-commits
mailing list