[PATCH] D118661: [AMDGPU] Check atomics aliasing in the clobbering annotation

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 1 02:12:39 PST 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp:51
     AU.addRequired<MemorySSAWrapperPass>();
     AU.setPreservesAll();
  }
----------------
Should add an addUsedIfAvailable call for AA here. But I think MemorySSA already requires it, so you could make it a hard requirement here too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118661/new/

https://reviews.llvm.org/D118661



More information about the llvm-commits mailing list