[PATCH] D118486: [demangler] Improve ->* & .* demangling

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 6 19:29:25 PST 2022


ChuanqiXu added inline comments.


================
Comment at: libcxxabi/src/demangle/ItaniumDemangle.h:1804
     OB += Kind;
+    bool IsPtr = Kind.back() == '*';
+    if (IsPtr)
----------------
Should we add a comment here? It is confusing for reader who don't have a background.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118486/new/

https://reviews.llvm.org/D118486



More information about the llvm-commits mailing list