[llvm] 1b27940 - Revert rG7275de7fb2f087871611d037d1b529b226dd0521 "[AArch64] translateLocChar - silence dead code warning"

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2022-02-06T17:19:23Z
New Revision: 1b27940a112c7c715fd8b62b6b483e2bb1f5d84d

URL: https://github.com/llvm/llvm-project/commit/1b27940a112c7c715fd8b62b6b483e2bb1f5d84d
DIFF: https://github.com/llvm/llvm-project/commit/1b27940a112c7c715fd8b62b6b483e2bb1f5d84d.diff

LOG: Revert rG7275de7fb2f087871611d037d1b529b226dd0521 "[AArch64] translateLocChar - silence dead code warning"

Seems to cause some buildbot misbehaviour (+ there's a dumb copy+paste typo in the commit message....)

Added: 
    

Modified: 
    llvm/lib/Support/FormatVariadic.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/FormatVariadic.cpp b/llvm/lib/Support/FormatVariadic.cpp
index 46573e745247..f6d48bcd50e8 100644
--- a/llvm/lib/Support/FormatVariadic.cpp
+++ b/llvm/lib/Support/FormatVariadic.cpp
@@ -18,8 +18,10 @@ static Optional<AlignStyle> translateLocChar(char C) {
     return AlignStyle::Center;
   case '+':
     return AlignStyle::Right;
+  default:
+    return None;
   }
-  return None;
+  LLVM_BUILTIN_UNREACHABLE;
 }
 
 bool formatv_object_base::consumeFieldLayout(StringRef &Spec, AlignStyle &Where,