[PATCH] D118526: [llvm-objcopy][MachO] Ignore LC_LINKER_OPTION when redefining symbols
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 6 02:23:09 PST 2022
alexander-shaposhnikov added inline comments.
================
Comment at: llvm/test/tools/llvm-objcopy/MachO/redefine-symbol.s:46
+.linker_option "-lc"
.globl _func
----------------
@keith - this test is not a good place for adding various load commands.
I'd recommend to add a separate test (until we have a test that specifically verifies all the copied-over load commands) (and remove this directive from redefine-symbol.s)
(if yaml supports LC_LINKER_OPTION - yaml-based, if it doesn't - assembly-based)
(the test should invoke `llvm-objcopy` without any extra flags)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118526/new/
https://reviews.llvm.org/D118526
More information about the llvm-commits
mailing list