[PATCH] D118653: [memprof] Extend the index prof format to include memory profiles.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/MemProf.h:123
+  PACKED(struct Frame {
+    uint64_t Function;
     uint32_t LineOffset;
----------------
davidxl wrote:
> Document type -- MD5 Hash
Can we use GlobalValue::GUID as the type (which is uint64_t)? That's already used elsewhere in this directory (at least in the SampleProfiler). If so, then the later md5 hash computation can call the static helper Function::getGUID on the string (which is just a wrapper around MD5Hash but matches the type name).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118653/new/

https://reviews.llvm.org/D118653