[PATCH] D118857: [DWARF][codegen] Fix for Aranges when split inlining is present

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:76-77
 
-  if (Label)
+  if (ShouldEmitArangeLabel && Label)
     DD->addArangeLabel(SymbolCU(this, Label));
 
----------------
ayermolo wrote:
> dblaikie wrote:
> > Could this be moved to above line 74 and then removed from the `addLocalLabelAddress` rather than duplicated? (would avoid needing to pass the extra parameter to `addLocalLabelAddress`)
> addLocalLabelAddress is a public API. Right now it's only used from here, but in the future if someone else uses it, they will need to know that addArangeLabel needs to be called before it is invoked. Maybe just eliminate it entirely and move functionality into addLabelAddress?
LLVM's concept of "public" API is fairly loose. We move functionality around pretty regularly.

I don't mind too much rolling the functionality in, it's not a very long function. Either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118857/new/

https://reviews.llvm.org/D118857