[PATCH] D119023: [flang] Adding options to the CfgConversion pass

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 4 16:06:28 PST 2022


mehdi_amini added inline comments.


================
Comment at: flang/test/Fir/cfg-options.fir:6
+// RUN: fir-opt %t/if.fir --cfg-conversion="transform-iterate-while=0" | FileCheck %t/if.fir
+// RUN: fir-opt %t/while.fir --cfg-conversion="transform-do-loop=0 transform-if=0" | FileCheck %t/while.fir
+
----------------
Isn't it a bit more maintainable to have separate files instead?

They'll show as separate failure if any is failing, it is easier to reproduce issues, and in general long files are annoying to work with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119023/new/

https://reviews.llvm.org/D119023



More information about the llvm-commits mailing list