[PATCH] D118995: [WebAssembly] Refactor and fix emission of external IR global decls

Fri Feb 4 11:48:48 PST 2022

pmatos added a comment.

In D118995#3297627 <https://reviews.llvm.org/D118995#3297627>, @pmatos wrote:

> In D118995#3297475 <https://reviews.llvm.org/D118995#3297475>, @sbc100 wrote:
>
>> In D118995#3297466 <https://reviews.llvm.org/D118995#3297466>, @pmatos wrote:
>>
>>> @sbc100 might have an incorrect version of node as I keep getting `/usr/bin/node: invalid value for --unhandled-rejections`. Other than that there are no failures. 
>>> Maybe you can give it a go on your side just to be certain before landing?
>>
>> Yup, sounds unrelated to this change, ... is that just a warning or do one or more tests fail?  What version is /usr/bin/node (we should probably detect this incompatibility)?
>
> Only the fails related to the warning:
>
>   test_openjpeg (test_core.core2) ... FAIL
>   -- begin program output --
>   /usr/bin/node: invalid value for --unhandled-rejections
>   -- end program output --
>
>   node --version
>   v12.22.5
>
> It's the ubuntu 21.10 version. What's the minimum version for emscripten?

Version 16.x of node is giving better results but still have tests failing with:

  test_unaligned (test_core.core2) ... skipped 'LLVM marks the reads of s as fully aligned, making this test invalid'
  -- begin program output --
  /usr/bin/node: bad option: --experimental-wasm-bigint
  -- end program output --

I guess I need 17.x or so...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118995/new/

https://reviews.llvm.org/D118995