[PATCH] D118960: [mte] [nfc] do not keep Tag in AllocaInfo

[Florian Mayer via Phabricator via llvm-commits]

fmayer added a comment.

In D118960#3297625 <https://reviews.llvm.org/D118960#3297625>, @eugenis wrote:

> Not sure about this. I kind of like that isInterestingAlloca is called only once for each alloca - this way it can run heavier analysis (it does not right now) and it is also allowed to change its mind (ex. after we add some instrumentation to the function).

That's fair. I was torn between the two approaches (the other way would be to change HWASan to resemble the current state of MTE stack tagging). I thought this has less room for error from forgetting to check for interestingness (because it's not in the list to begin with), and because as you said isInterestingAlloca doesn't do anything particularly expensive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118960/new/

https://reviews.llvm.org/D118960