[PATCH] D119019: [ADT] Add APInt/MathExtras isShiftedMask variant returning mask offset/length

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 4 11:19:22 PST 2022


foad added inline comments.


================
Comment at: llvm/include/llvm/ADT/APInt.h:499
 
+  /// Return true if this APInt value contains a sequence of ones with
+  /// the remainder zero. If true, \p MaskIdx will specify the index of the
----------------
Should probably say it's a non-empty sequence of ones, like you do in MathExtras.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119019/new/

https://reviews.llvm.org/D119019



More information about the llvm-commits mailing list