[PATCH] D118995: [WebAssembly] Refactor and fix emission of external IR global decls

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Are you able to verify this against emscripten?  Perhaps run the core2 test suite there?  If not let me know and I can give it a go.



================
Comment at: llvm/test/CodeGen/WebAssembly/only-data.ll:2
+; RUN: llc < %s --mtriple=wasm32-unknown-unknown -asm-verbose=false -mattr=+reference-types | FileCheck %s
+
+;      CHECK: .type foo, at object
----------------
How about adding a comment about why we do this?  "Verify that types are output for external symbols, even in the absence of any defined functions".


================
Comment at: llvm/test/CodeGen/WebAssembly/only-data.ll:14
+declare i32 @bar(i32 noundef)
+
----------------
Remove trailing newline


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118995/new/

https://reviews.llvm.org/D118995