[PATCH] D118994: [AMDGPU] SILoadStoreOptimizer: rewrite checkAndPrepareMerge. NFCI.

[Piotr Sobczak via Phabricator via llvm-commits]

piotr accepted this revision.
piotr added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:949
 
-    // Handle a case like
-    //   DS_WRITE_B32 addr, v, idx0
-    //   w = DS_READ_B32 addr, idx0
-    //   DS_WRITE_B32 addr, f(w), idx1
-    // where the DS_READ_B32 ends up in InstsToMove and therefore prevents
-    // merging of the two writes.
-    if (addToListsIfDependent(*MBBI, RegDefsToMove, PhysRegUsesToMove,
-                              InstsToMove))
-      continue;
+    // When we match I with another DS instruction we will be moving I down
+    // to the location of the matched instruction any uses of I will need to
----------------
Not related to your change, but the mention of "DS" is a left-over from the times this pass only handled ds_read/ds_write. Can you please remove it before committing (no need to resubmit)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118994/new/

https://reviews.llvm.org/D118994