[PATCH] D118193: [llvm-nm] add a new option -X to specify the type of object file llvm-nm should examine

[Digger Lin via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/option-X-invalid-arg.test:7
+
+# CHECK:      llvm-nm{{(\.exe)?}}: error: : -X value should be one of: 32, 64, 32_64, (default) any
+# CHECK-NEXT: global_data_symbol32
----------------
MaskRay wrote:
> It's not necessary to test the filename part. 
> 
> Is there a stray colon in `: : `?
yes, there is ": : " output


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118193/new/

https://reviews.llvm.org/D118193