[PATCH] D118992: [flang] Add lowering for ASCII character constant

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Including this in D118993 <https://reviews.llvm.org/D118993> would be better.



================
Comment at: flang/lib/Lower/ConvertExpr.cpp:254
+                    int64_t len) {
+    assert(value.size() == static_cast<std::uint64_t>(len));
+    return fir::factory::createStringLiteral(builder, getLoc(), value);
----------------
Nit: may be an assert message also.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118992/new/

https://reviews.llvm.org/D118992