[PATCH] D118799: [ConstraintElimination] Allow adding pre-conditions for constraints.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added a comment.

In D118799#3293826 <https://reviews.llvm.org/D118799#3293826>, @reames wrote:

> LGTM
>
> Code looks reasonable, don't have a ton of context so I'm assuming the existing code does what it says.  If you want a more rigorous review, ask and I'll take a more skeptical pass through.

Thanks for taking a look, the general/high-level sanity check is very much appreciated!



================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:82
     append_range(Constraints, Other.Constraints);
+    append_range(Preconditions, Other.Preconditions);
   }
----------------
reames wrote:
> I'll note we can do smarter merges here in some cases, but we can defer fanciness until warranted.
Good point! I'll add a TODO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118799/new/

https://reviews.llvm.org/D118799