[PATCH] D116465: [SPIRV 6/6] Add 2 essential passes and the simplest tests

Fri Feb 4 02:56:08 PST 2022

rengolin added a comment.

In D116465#3295139 <https://reviews.llvm.org/D116465#3295139>, @iliya-diyachkov wrote:

> So if we don't have obvious solutions for the 1st and 2nd issues, I would add this suggestion to the TODO list (we'll take it in mind during further code revisions) and go forward with the existing GlobalTypesAndRegNumPass.

Agreed. With that in mind, this looks good to me.

I'll let the other reviewers have the final approval, just to make sure we all agree.

Thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116465/new/

https://reviews.llvm.org/D116465