[PATCH] D118450: [RuntimeDyld] Handle SPARC

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

HI Rainer,

Sorry, I've been busy and haven't had a chance to review this yet. I should be able to take a look this week or next.

The first thing that I notice is that this is missing a testcase. I don't think we had infrastructure to test this with in LLVM 3, but it should now be testable with an llvm-rtdyld test (see `llvm/test/ExecutionEngine/RuntimeDyld/*/` for examples).

Is there a motivating use case for adding this support? Where possible, new development should focus on JITLink rather than RuntimeDyld, but if there are existing MCJIT users on SPARC who need this then I think it makes sense to upstream it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118450/new/

https://reviews.llvm.org/D118450