[PATCH] D118376: [x86] try harder to scalarize a vector load with extracted integer op uses

Haowei Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 19:02:48 PST 2022


haowei added a comment.

In D118376#3293280 <https://reviews.llvm.org/D118376#3293280>, @spatel wrote:

> In D118376#3292090 <https://reviews.llvm.org/D118376#3292090>, @haowei wrote:
>
>> Hi, we found out that this patch breaks following tests in the Fuchsia's stage-2 mac clang builders:
>>
>>   Clang :: Refactor/Extract/ExtractExprIntoFunction.cpp
>>   Clang :: Refactor/Extract/ExtractionSemicolonPolicy.cpp
>>   Clang :: Refactor/Extract/ExtractionSemicolonPolicy.m
>>   Clang :: Refactor/Extract/FromMethodToFunction.cpp
>>   Clang :: Refactor/Extract/ObjCProperty.m
>>
>> An example of the failure: https://ci.chromium.org/ui/p/fuchsia/builders/prod/clang-mac-x64/b8823769353085181809/overview . And test error messages can be found at https://ci.chromium.org/ui/p/fuchsia/builders/prod/clang-mac-x64/b8823769353085181809/test-results . These failures only happens in stage 2 build so it took us some time to bisect and confirm it. Could you take a look please? And if it takes a long time to fix, could you revert this change first please? Thanks.
>
> Thanks for letting me know. I don't have a system set up to debug a stage 2 failure, so this is going to take a while unless someone else has a way to diagnose/reduce the errors more quickly. I will revert within a day if there is no update/progress.

I am not an expert on Mac. I did some experiments. Using the clang built from this revision (b4b97ec813a02585000f30ac7d532dda74e8bfda <https://reviews.llvm.org/rGb4b97ec813a02585000f30ac7d532dda74e8bfda>) to build stage 2 clang, regardless of the revision of the second stage clang, will cause clang-refactor related test to fail.  So I think this patch introduced a bug that changed clang's code gen behavior and cause clang to generate buggy code on the Mac. I still don't quite understand why the clang-refactor tool is the only one affected so far. If you need any binaries from stage 1 and 2 build to debug this issue, please let me know. I can help build them for you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118376/new/

https://reviews.llvm.org/D118376



More information about the llvm-commits mailing list