[PATCH] D118756: [ELF] Avoid wrapping unreferenced lazy symbols

Thu Feb 3 17:10:32 PST 2022

smeenai marked 7 inline comments as done.
smeenai added a comment.

In D118756#3292677 <https://reviews.llvm.org/D118756#3292677>, @MaskRay wrote:

> Consider deleting `wrap-with-archive.s` (D56110 <https://reviews.llvm.org/D56110>) since the new wrap-lazy.test is more comprehensive.

That test seems to be covering the interaction between linker-defined symbols and wrapping specifically (see D56110 <https://reviews.llvm.org/D56110>). I undid the code change from D56110 <https://reviews.llvm.org/D56110>, and wrap-with-archive.s failed but wrap-lazy.test still passed. I could theoretically extend wrap-lazy.test to cover that case as well, but it'd be mixing multiple concerns into one test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118756/new/

https://reviews.llvm.org/D118756