[PATCH] D116784: [ProfileData] Read and symbolize raw memprof profiles.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added inline comments.


================
Comment at: llvm/lib/ProfileData/CMakeLists.txt:21
   Core
+  Object
   Support
----------------
thakis wrote:
> Object is already present 3 lines further down. Maybe alphabetize this list and remove the dupe :)
I sorted and deduped this list but that broke the clang ppc buildbot so I reverted the change.

https://reviews.llvm.org/rG55de669660cb1523cf83c98e8c0cb133ec279383


================
Comment at: llvm/lib/ProfileData/CMakeLists.txt:25
   Object
+  Symbolize
   DebugInfoDWARF
----------------
thakis wrote:
> This dependency is a problem. At the moment, Symbolize adds a dep to libcurl, and clang transitiviely depends on llvm/lib/ProfileData. So this makes clang depend on libcurl (even in statically linked builds), which is something we want to avoid. See also the discussion on D113717 (in particular, https://reviews.llvm.org/D113717#3295350).
> 
> Since this likely has no super quick fix, would you mind reverting this until that dependency can be prevented somehow?
I assume you mean this patch and not the sort/dedupe suggestion above. Reading through the discussion then we would have to wait for a refactoring to move the libcurl dep to llvm-symbolize instead of debuginfod. Is it possible to split debuginfod out of Symbolize so that we can unblock this patch sooner?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116784/new/

https://reviews.llvm.org/D116784