[PATCH] D110579: [AMDGPU] Add a new intrinsic to control fp_trunc rounding mode

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 15:47:55 PST 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6355
+
+    SmallVector<EVT, 4> ValueVTs;
+    ComputeValueVTs(TLI, DAG.getDataLayout(), I.getType(), ValueVTs);
----------------
You probably don't need ComputeValueVTs. There shouldn't be any structs or arrays here that need to broken down. I think you can do

```
EVT VT = TLI.getValueType(I.getType)
```

And then use `VT` in place of `VTs`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110579/new/

https://reviews.llvm.org/D110579



More information about the llvm-commits mailing list