[PATCH] D118299: [Spill2Reg] This patch adds spill/reload collection.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 15:26:05 PST 2022


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/Spill2Reg.cpp:160
+        auto &Entry = StackSlotData[StackSlot];
+        unsigned MemBits = TRI->getRegSizeInBits(MO->getReg(), *MRI);
+        if (SkipEntry(StackSlot, MemBits, MI.getOpcode())) {
----------------
I wouldn't assume the memory size is the same as the register size


================
Comment at: llvm/lib/CodeGen/Spill2Reg.cpp:201
+
+  // Replace each spills/reloads to stack slots with register spils/reloads.
+  generateCode();
----------------
Typo spils


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118299/new/

https://reviews.llvm.org/D118299



More information about the llvm-commits mailing list