[PATCH] D118303: [Spill2Reg] Added live register tracking.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/Spill2Reg.cpp:256-260
+/// Perform a bottom-up depth-first traversal from \p MBB at \p MI towards its
+/// predecessors blocks. Visited marks the visited blocks. \p Fn is the
+/// callback function called in pre-order. If \p Fn returns true we stop the
+/// traversal.
+static void DFS(MachineBasicBlock *MBB, DenseSet<MachineBasicBlock *> &Visited,
----------------
Why can't you use df_iterator?


================
Comment at: llvm/lib/CodeGen/Spill2Reg.cpp:323
+
+  /// Wlaks up the instructions in \p Reload's block, stopping at a spill if
+  /// found. \Returns true if a spill was found, false otherwise.
----------------
Typo Wlaks


================
Comment at: llvm/lib/CodeGen/Spill2Reg.cpp:353
+      return true;
+    } else {
+      // Else this is an intermediate block between the spills and reloads and
----------------
No else after return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118303/new/

https://reviews.llvm.org/D118303