[PATCH] D118945: [lld-macho] Minor clean up: use .find() to check for key existence rather than [], which would create a new entry.

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 14:16:18 PST 2022


oontvoo added a comment.

In D118945#3295074 <https://reviews.llvm.org/D118945#3295074>, @keith wrote:

> Thanks I wasn't aware of this, but it looks like this was the only one doing this.

Yeah I hadn't noticed this until I ran this code with a readlock (not a write lock) and got a crash due to concurrent writes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118945/new/

https://reviews.llvm.org/D118945



More information about the llvm-commits mailing list