[PATCH] D115401: AMDGPU: Fix clobbering SCC when expanding large offset spill pseudos

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/swdev309419-agpr.mir:3
+# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 -verify-machineinstrs -run-pass=prologepilog %s -o - | FileCheck -check-prefix=GFX908 %s
+# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a -verify-machineinstrs -run-pass=prologepilog %s -o - | FileCheck -check-prefix=GFX90A %s
+---
----------------
arsenm wrote:
> rampitec wrote:
> > Probably add run line with flat scratch and another with -mattr=+architected-flat-scratch.
> Doesn't architected flat scratch just changed the prolog initialization? Why does it matter here?
Technically it also eliminates wave scratch offset. I doubt you can run into a problem here since flat scratch path shall not use it after initialization, just a precaution.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115401/new/

https://reviews.llvm.org/D115401