[PATCH] D118931: [llvm-libtool-darwin] Add -warnings_as_errors

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Ideally we'd have a way to automatically turn warnings into errors past a certain threshold (similar to how LLD's error handler does it), but given that we only have two warnings right now, that's probably overkill. This LGTM.



================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:380
+        if (WarningsAsErrors)
+          return createFileError(
+              Member.MemberName,
----------------
Would creating this as an Error and passing it to `WithColor::defaultWarningHandler` (as is done in the other case) work here as well, just to reduce the duplication?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118931/new/

https://reviews.llvm.org/D118931