[PATCH] D118909: [AMDGPU] Simplify AMDGPUAnnotateUniformValues::visitLoadInst
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 3 12:06:32 PST 2022
rampitec added a comment.
In D118909#3294654 <https://reviews.llvm.org/D118909#3294654>, @foad wrote:
> In D118909#3294509 <https://reviews.llvm.org/D118909#3294509>, @rampitec wrote:
>
>> We could even use a second target flag and mark loads as uniform directly.
>
> Sure, but I don't see a need to do that. "Uniform" really is a property of the pointer value, not of a particular load.
Agree, but we do not use that. Instead we are inspecting instructions in the isUniformMMO. I am just wondering if we miss some scalar cases that way. Maybe not and it is not needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118909/new/
https://reviews.llvm.org/D118909
More information about the llvm-commits
mailing list