[PATCH] D118756: [ELF] Avoid wrapping unreferenced lazy symbols

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/wrap-lazy.test:8
+# RUN: llvm-mc -filetype=obj -triple=x86_64-linux-gnu %t/ref.s -o %tref.o
+# RUN: llvm-ar crs %tliblazybitcode.a %tlazybitcode.o
+# RUN: llvm-ar crs %tliblazy.a %tlazy.o
----------------
smeenai wrote:
> MaskRay wrote:
> > Thanks for adding bitcode tests.
> > 
> > I think having both archive and --start-lib tests are redundant. You may remove archive tests.
> > 
> > `llvm-ar crs x.a` needs to remove the archive first, otherwise there is a risk that a dangling archive with more symbols can cause different symbol resolution results.
> Do you mean archive tests for the bitcode specifically, or all the other archive tests as well?
Either only keep --start-lib tests, or only keep archive tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118756/new/

https://reviews.llvm.org/D118756