[PATCH] D118575: [llvm-libtool-darwin] Fix crash with bitcode asm module

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a subscriber: int3.
smeenai added a comment.

I don't have direct experience with this either, but this seems sensible (I assume `InitializeAllTargets` is a pre-req for `InitializeAllAsmParsers`, although llvm-ar is just using `InitializeAllTargetInfos`). I'll let it sit for a few days to give others the chance to chime in though.

CC @int3, who set up LTO for LLD for Mach-O.



================
Comment at: llvm/test/tools/llvm-libtool-darwin/asm.test:1
+## This tests that archives are correctly created when the llvm
+## has native assembly info
----------------
I think you'll want `REQUIRES` lines for the targets you're using here (`x86` and `aarch64`), to make the test not fail when LLVM is built without those targets. (I think just testing one architecture would be fine as well, to not require multiple targets to be enabled for running the test).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118575/new/

https://reviews.llvm.org/D118575