[PATCH] D116465: [SPIRV 6/6] Add 2 essential passes and the simplest tests

Thu Feb 3 09:01:39 PST 2022

rengolin added a comment.

In D116465#3293994 <https://reviews.llvm.org/D116465#3293994>, @zuban32 wrote:

> Not sure how we can control the VReg IDs emitted for the types - it seems it'd require customizing IRTranslator which is not allowed by the current GlobalISel design. Am I missing something?

As I said, I haven't worked with MIR directly (it was after my time on back-ends), so very likely I am the one missing context.

I don't mind this as it is on an experimental target, but it would be nice to not have to do that in the long run (though, it wouldn't be tragic either).

If @arsenm and @MaskRay are happy with this patch, I'm happy too. I'll let them approve this one.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116465/new/

https://reviews.llvm.org/D116465