[PATCH] D118909: [AMDGPU] Simplify AMDGPUAnnotateUniformValues::visitLoadInst

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 07:32:27 PST 2022


foad created this revision.
foad added reviewers: arsenm, rampitec, alex-t, critson.
Herald added subscribers: kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, MatzeB.
foad requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Always set uniform metadata on the pointer if it is an instruction, but
otherwise do not bother to create a trivial getelementptr instruction,
because AMDGPUInstrInfo::isUniformMMO can already detect that various
non-instruction pointers are uniform.

Most of the test case churn is from tests that used undef as a pointer,
which AMDGPUInstrInfo::isUniformMMO treats as uniform.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118909

Files:
  llvm/lib/Target/AMDGPU/AMDGPUAnnotateUniformValues.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-amdgpu_kernel.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-call.ll
  llvm/test/CodeGen/AMDGPU/cvt_f32_ubyte.ll
  llvm/test/CodeGen/AMDGPU/fdiv.f64.ll
  llvm/test/CodeGen/AMDGPU/global-variable-relocs.ll
  llvm/test/CodeGen/AMDGPU/nested-loop-conditions.ll
  llvm/test/CodeGen/AMDGPU/noclobber-barrier.ll
  llvm/test/CodeGen/AMDGPU/rcp-pattern.ll
  llvm/test/CodeGen/AMDGPU/si-annotate-cf.ll
  llvm/test/CodeGen/AMDGPU/vgpr-liverange-ir.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118909.405637.patch
Type: text/x-patch
Size: 59665 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220203/4a996325/attachment.bin>


More information about the llvm-commits mailing list