[PATCH] D118903: [lld-macho] Have relocation address included in range-check error message

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 06:54:50 PST 2022


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This makes it easier to debug those errors. See e.g. https://github.com/llvm/llvm-project/issues/52767#issuecomment-1028713943

We take the approach of 'reverse-engineering' the InputSection from the
output buffer offset. This provides for a cleaner Target API, and is
similar to LLD-ELF's implementation of getErrorPlace().


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D118903

Files:
  lld/MachO/Arch/ARM64Common.cpp
  lld/MachO/Arch/ARM64Common.h
  lld/MachO/Arch/X86_64.cpp
  lld/MachO/Relocations.cpp
  lld/MachO/Relocations.h
  lld/MachO/SyntheticSections.h
  lld/MachO/Writer.cpp
  lld/test/MachO/invalid/range-check.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118903.405626.patch
Type: text/x-patch
Size: 16188 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220203/dc6d2111/attachment.bin>


More information about the llvm-commits mailing list