[PATCH] D118769: Split fast-basictest.ll according to passes responsible for optimizations

Daniil Kovalev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 06:40:51 PST 2022


kovdan01 added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/fast-reassociate-gvn.ll:12-13
+;
+; RUN: opt < %s -reassociate -gvn -S | FileCheck %s --check-prefix=REASSOC_AND_GVN
+; RUN: opt < %s -O2 -S | FileCheck %s --check-prefix=O2
+
----------------
spatel wrote:
> We can reduce the number (maybe eliminate all) of the duplicated check lines by using a shared prefix. Try something like this:
> 
> ```
> ; RUN: opt < %s -reassociate -gvn -S | FileCheck %s --check-prefixes=CHECK,REASSOC_AND_GVN
> ; RUN: opt < %s -O2 -S | FileCheck %s --check-prefixes=CHECK,O2
> ```
Thanks for that hint! Fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118769/new/

https://reviews.llvm.org/D118769



More information about the llvm-commits mailing list