[PATCH] D118793: [COFF] Move section name encoding into BinaryFormat

Nicolas Miller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 3 02:35:31 PST 2022


npmiller updated this revision to Diff 405555.
npmiller added a comment.

Fixed file order in `CMakeLists.txt`, removed unnecessary `*- C++-*` in `.cpp` source file.

For the `NameSize` comment I simply added the namespace, `COFF::NameSize`, which should make it clear that it's referring to the constant value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118793/new/

https://reviews.llvm.org/D118793

Files:
  llvm/include/llvm/BinaryFormat/COFF.h
  llvm/lib/BinaryFormat/CMakeLists.txt
  llvm/lib/BinaryFormat/COFF.cpp
  llvm/lib/MC/WinCOFFObjectWriter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118793.405555.patch
Type: text/x-patch
Size: 5300 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220203/f4f6909f/attachment.bin>


More information about the llvm-commits mailing list