[PATCH] D116465: [SPIRV 6/6] Add 2 essential passes and the simplest tests

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In D116465#3292079 <https://reviews.llvm.org/D116465#3292079>, @zuban32 wrote:

> Which stage are you talking about here: InstPrinter, any post-InstructionSelection pass, etc? On gMIR level I don't understand how that'd work if we define VReg %1 in func f1 and then use it in both f1 and f2.

Whatever level you were planning to do the de-duplication. My point is just to replace de-duplication by enforcement (as post-generation pass) to de-duplication by construction (a singleton generator).

Though, I am not super familiar with MIR's representation, as that was introduced after I stopped working on back-ends directly, so don't take my word on that.

Perhaps @arsenm can chime in?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116465/new/

https://reviews.llvm.org/D116465