[PATCH] D118841: [RISCV] Remove RISCVISD::SPLAT_VECTOR_I64 in favor of RISCVISD::VMV_V_X_VL.
    Fraser Cormack via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Feb  3 02:02:44 PST 2022
    
    
  
frasercrmck added a comment.
Seems like a good cleanup to me, thanks. Maybe one thing would be to include in the description the rationale for swapping VSD and VVL .td files?
================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:1907
 
-  // ISD::SPLAT_VECTOR, RISCVISD::SPLAT_VECTOR_I64 and RISCVISD::VMV_V_X_VL
+  // ISD::SPLAT_VECTOR, RISCVISD::VMV_V_X_VL
   // share semantics when the operand type is wider than the resulting vector
----------------
nit: reflow this comment?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118841/new/
https://reviews.llvm.org/D118841
    
    
More information about the llvm-commits
mailing list