[PATCH] D117944: [AARCH64][NEON] Allow to sink operands for aarch64_neon_pmull.

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Looks like a good patch, from what I can see. Thanks

LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12163
+    case Intrinsic::aarch64_neon_pmull:
+      if (!areExtractShuffleVectors(II->getOperand(0), II->getOperand(1))) {
+        return false;
----------------
You don't need brackets around single statements in llvm. I would personally also invert the condition - if (thing) doathing() seems clearer in intent to me, but I do see that other cases here work the other way arounds already.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117944/new/

https://reviews.llvm.org/D117944