[PATCH] D116857: [libunwind] [sparc] Add SPARCv9 support

[Arfrever Frehtes Taifersar Arahesis via Phabricator via llvm-commits]

Arfrever added inline comments.


================
Comment at: libunwind/src/Registers.hpp:3642
+
+  uint64_t  getSP() const         { return _registers.__regs[UNW_SPARC_O6] + 2047; }
+  void      setSP(uint64_t value) { _registers.__regs[UNW_SPARC_O6] = value - 2047; }
----------------
koakuma wrote:
> Arfrever wrote:
> > Formatting of this `getSP()` method is not aligned with formatting of other methods in this class.
> I think `getSP()` until `getWCookie()` has been aligned properly.
> 
> Or do you mean that I should align those with `getArch()` and the methods above it? Currently I'm just following the formatting of other register classes where `getSP()` onwards have different alignment than previous methods.
OK. The long "Lint: Pre-merge checks" comment made it so that I did not see that this line is aligned with lines below.
I withdraw this one suggestion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116857/new/

https://reviews.llvm.org/D116857